Question

I cannot figure out why my random name generator isn't producing the letter u or z. Can someone help me out? The language is java.

import java.util.Random;

public class BrandName {

   public static void main(String[] args) {
       Random random = new Random();
       System.out.println("Brand Name Generator - Michael Wikstrom\n");
       char odd[] = { 'b', 'c', 'd', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'p', 'r', 's', 't', 'v', 'w', 'x', 'y',
               'z' };
       char even[] = { 'a', 'e', 'i', 'o', 'u' };

       for (int i = 1; i <= 10; i++) {

           int length = random.nextInt(4) + 8;
           String name = " ";
           for (int j = 0; j < length; j++) {
               if (j == 0) {
                   int pos = random.nextInt(odd.length - 1);
                   name += Character.toUpperCase(odd[pos]);

               } else if (j % 2 == 1) {
                   int pos = random.nextInt(even.length - 1);
                   name += even[pos];
               } else {
                   int pos = random.nextInt(odd.length - 1);
                   name += odd[pos];
               }
           }

           System.out.println(i + ") " + name);

       }
   }

}

Answer 1

Please find your solution below and do upvote if doubt comment.

• The problems are due to : random.nextInt(n)
• This will return a rundom number from 0(inclusive) to n(exclusive) i.e only 0 to n-1 number will be retuned.
• Same in the given code random.nextInt(odd.length - 1) the odd array length is 20 and then the function will be random.nextint(19) i.e it will return number from 0 to 18 only so the last index position which is 19(position of z) is excluded that's why z is not being produced.
• Same with the random.nextInt(even.length-1) the length of even array is 5 so the function be random.nextInt(4) i.e it will generate number from 0 to 3 only so the last index position which is 4(position of u) is excluded that's why u is not being produced.

Corrected code:

import java.util.Random;

public class BrandName {

   public static void main(String[] args) {
       Random random = new Random();
       System.out.println("Brand Name Generator - Michael Wikstrom\n");
       char odd[] = { 'b', 'c', 'd', 'f', 'g', 'h', 'j', 'k', 'l', 'm', 'n', 'p', 'r', 's', 't', 'v', 'w', 'x', 'y','z' };
       char even[] = { 'a', 'e', 'i', 'o', 'u' };

       for (int i = 1; i <= 10; i++) {

           int length = random.nextInt(4) + 8;
           String name = " ";
           for (int j = 0; j < length; j++) {
               if (j == 0) {
                   int pos = random.nextInt(odd.length);
                   name += Character.toUpperCase(odd[pos]);

               } else if (j % 2 == 1) {
                   int pos = random.nextInt(even.length);
                   name += even[pos];
               } else {
                   int pos = random.nextInt(odd.length);
                   name += odd[pos];
               }
           }

           System.out.println(i + ") " + name);

       }
   }

}